drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aman Sinha (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-1992) Add more stats for HashJoinBatch and HashAggBatch
Date Tue, 13 Jan 2015 16:43:35 GMT

    [ https://issues.apache.org/jira/browse/DRILL-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14275515#comment-14275515
] 

Aman Sinha commented on DRILL-1992:
-----------------------------------

I saw in one place memoryAllocated is an int...you should change it to long.   The getBufferCapacity()
method is implemented in 2 of the vector template classes..is that sufficient ? 
Rest of the changes look good to me ...more stats is always better !
+1 

> Add more stats for HashJoinBatch and HashAggBatch
> -------------------------------------------------
>
>                 Key: DRILL-1992
>                 URL: https://issues.apache.org/jira/browse/DRILL-1992
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Execution - Operators
>    Affects Versions: 0.8.0
>            Reporter: Venki Korukanti
>            Assignee: Venki Korukanti
>             Fix For: 0.8.0
>
>         Attachments: DRILL-1992.patch
>
>
> Adding more stats to analyze the memory usage of HashJoinBatch and HashAggBatch.
> HashJoinBatch
>   + HASHTABLE_MEMORY_ALLOCATION
>   + HASHTABLE_NUM_BATCHHOLDERS
>   + HASHJOINHELPER_MEMORY
> HashAgg
>   + HASHTABLE_MEMORY_ALLOCATION
>   + HASHTABLE_NUM_BATCHHOLDERS
>   + HASHAGG_MEMORY
>   + HASHAGG_NUM_BATCHHOLDERS
> Cleanup:
>   + Prefix "HASHTABLE_" to existing HashTable metrics such as NUM_BUCKETS.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message