drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jacques Nadeau (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (DRILL-340) Ensure methods intended to create new copies of plan nodes are actually creating copies of all nested objects
Date Sun, 04 Jan 2015 21:29:39 GMT

     [ https://issues.apache.org/jira/browse/DRILL-340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jacques Nadeau resolved DRILL-340.
----------------------------------
    Resolution: Won't Fix

> Ensure methods intended to create new copies of plan nodes are actually creating copies
of all nested objects
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: DRILL-340
>                 URL: https://issues.apache.org/jira/browse/DRILL-340
>             Project: Apache Drill
>          Issue Type: Bug
>            Reporter: Jason Altekruse
>             Fix For: Future
>
>
> Methods such as getNewWithChildren declared in the PhysicalOperator interface are designed
to create copies of plan nodes. These copy operations should not reference any part of the
old nodes, thus child objects should be deep copied, including lists of objects. For more
information on the desired functionality see here: http://en.wikipedia.org/wiki/Clone_(Java_method)
> Existing implementations should be checked for correctness. We may want to create this
functionality for logical operators as well, but I do not believe that we should need to do
manipulations on logical plans that would require it. Our optimization of plans will happen
in the logical to physical plan transformation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message