drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jinfeng Ni (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-1488) Limit on file name in sql query is too small
Date Thu, 13 Nov 2014 01:36:33 GMT

    [ https://issues.apache.org/jira/browse/DRILL-1488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14209064#comment-14209064
] 

Jinfeng Ni commented on DRILL-1488:
-----------------------------------

I have a fix, which increase the max length to 1024, and the query originally failed now runs
successfully.

{code}
select * from dfs.`/Users/jni/work/data/json/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa.json`;
+------------+
|     a      |
+------------+
| [{"x":[[1],[2,20],[3,30,300]],"y":"abc"},{"x":[[1],[2,20],[3,30,300]],"y":"abc"}] |
| [{"x":[[1000]],"y":"abc2"}] |
+------------+
2 rows selected (1.137 seconds)
{code}

However, given the fact Drill allows user to query any file/directory in the local/distributed
file system, 1024 could not be big enough. I'm wondering whether it's a good fix by just simply
increasing the identifier's length. 



> Limit on file name in sql query is too small
> --------------------------------------------
>
>                 Key: DRILL-1488
>                 URL: https://issues.apache.org/jira/browse/DRILL-1488
>             Project: Apache Drill
>          Issue Type: Bug
>    Affects Versions: 0.6.0
>            Reporter: Parth Chandra
>            Assignee: Jinfeng Ni
>             Fix For: 0.7.0
>
>
> While building from the release tarball, unit test fail if you build from a directory
that is nested several levels deep such that the full path to some of the test data files
is longer than 128 characters.
> The limit appears to be very small and should be increased.
> One of the errors during the build that illustrates the problem: 
> testTextJoin(org.apache.drill.TestExampleQueries)  Time elapsed: 0.011 sec  <<<
ERROR!
> org.apache.drill.exec.rpc.RpcException: Failure while parsing sql. Length of identifier
'file:/Users/pchandra/work/drill-release/apache-drill-0.6.0-incubating-src/exec/java-exec/target/test-classes/store/text/data/nations.csv'
must be less than or equal to 128 characters [38933037-d38d-4278-a215-b722cc97811c]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message