drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aman Sinha (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-584) ExpressionTreeMaterializer injects incorrect implicit casts
Date Thu, 27 Nov 2014 00:09:12 GMT

    [ https://issues.apache.org/jira/browse/DRILL-584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14227030#comment-14227030
] 

Aman Sinha commented on DRILL-584:
----------------------------------

The patch itself looks ok to me; however I talked to Mehant and there's likely additional
function implementations needed to convert varbinary to date such that existing TPCH queries
work with this patch.  As agreed, I am assigning this to him. 

> ExpressionTreeMaterializer injects incorrect implicit casts
> -----------------------------------------------------------
>
>                 Key: DRILL-584
>                 URL: https://issues.apache.org/jira/browse/DRILL-584
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Execution - Codegen
>            Reporter: Mehant Baid
>            Assignee: Aman Sinha
>             Fix For: 0.7.0
>
>
> In ExpressionTreeMaterializer.visitFunctionCall() we try to get a best match between
the DrillFuncHolder and the input call. We may match the input call with a DrillFuncHolder
whose argument type is different from that of the input, but is allowed to be implicitly cast
as per the precedence rules. 
> However when we inject implicit casts to compensate for the difference in argument types,
we again use the same matching method to resolve the implicit cast to DrillFuncHolder. In
the case of implicit casts should not match with a DrillFuncHolder that has different argument
types than the input. We should return only the DrillFuncHolder that exactly matches the argument
types and if no such holder is present should return NULL.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message