drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steven Phillips (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-1505) Updating Session Value Doesn't Reflect In 'sys.options' Query Output
Date Wed, 08 Oct 2014 16:16:34 GMT

    [ https://issues.apache.org/jira/browse/DRILL-1505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14163679#comment-14163679
] 

Steven Phillips commented on DRILL-1505:
----------------------------------------

I'm not sure this is the best way to fix this. I am pretty sure the regression is caused by
this change in Foreman.java:

-      QueryWorkUnit work = parallelizer.getFragments(context.getOptions().getSessionOptionList(),
context.getCurrentEndpoint(),
+      QueryWorkUnit work = parallelizer.getFragments(context.getOptions().getOptionList(),
context.getCurrentEndpoint(),


In particular, I don't think remote fragment have access to the UserClientConnection (only
the root fragment has this). So the options need to be included in the PlanFragment.

I think what needs to happen is in Foreman, we need to merge the Session Options with the
query options when calling getOptions() on the QueryOptions.

> Updating Session Value Doesn't Reflect In 'sys.options' Query Output
> --------------------------------------------------------------------
>
>                 Key: DRILL-1505
>                 URL: https://issues.apache.org/jira/browse/DRILL-1505
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Execution - Flow
>    Affects Versions: 0.5.0
>            Reporter: MUFEED USMAN
>            Assignee: Aditya Kishore
>            Priority: Critical
>         Attachments: DRILL-1505-Updating-Session-Value-Doesn-t-Reflect-In.patch
>
>
> Even after updating the value for a session option, the value when queried reflects the
default value. How to know what is the value for the current session?
> [root@n69 bin]# ./sqlline -u jdbc:drill:zk=n69:5181,n72:5181,n73:5181 -n admin -p admin
> sqlline version 1.1.6
> 0: jdbc:drill:zk=n69:5181,n72:5181,n73:5181> alter session set `exec.errors.verbose`=true;
> +------------+------------+
> |     ok     |  summary   |
> +------------+------------+
> | true       | exec.errors.verbose updated. |
> +------------+------------+
> 1 row selected (0.185 seconds)
> 0: jdbc:drill:zk=n69:5181,n72:5181,n73:5181> select * from sys.options where name
= 'exec.errors.verbose';
> +------------+------------+------------+------------+------------+------------+------------+
> |    name    |    kind    |    type    |  num_val   | string_val |  bool_val  | float_val
 |
> +------------+------------+------------+------------+------------+------------+------------+
> | exec.errors.verbose | BOOLEAN    | SYSTEM     | null       | null       | false   
  | null       |
> +------------+------------+------------+------------+------------+------------+------------+
> 1 row selected (0.192 seconds)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message