drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mehant Baid (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-706) DIV function does not return the integer portion of result as expected
Date Wed, 02 Jul 2014 02:23:24 GMT

    [ https://issues.apache.org/jira/browse/DRILL-706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14049540#comment-14049540
] 

Mehant Baid commented on DRILL-706:
-----------------------------------

Similar review comment for this patch as provided for DRILL-988. I don't think you need to
use BigDecimal for non-fractional inputs (like int or long), the existing methods would work,
you probably only need to modify the methods for float and double.

> DIV function does not return the integer portion of result as expected
> ----------------------------------------------------------------------
>
>                 Key: DRILL-706
>                 URL: https://issues.apache.org/jira/browse/DRILL-706
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Functions - Drill
>    Affects Versions: 1.0.0-milestone-1
>            Reporter: Krystal
>            Assignee: Mehant Baid
>             Fix For: 1.0.0-BETA1
>
>         Attachments: DRILL-706-DRILL-524-union.patch, DRILL-706-DRILL-524-v2.patch, DRILL-706-DRILL-524-v3.patch,
DRILL-706-DRILL-524.patch, DRILL-706.patch, DRILL-988-DRILL-706-DRILL-524-union.patch
>
>
> Based on the spec for DIV(x,y) function, the function suppose to return the integer part
of x/y.  However, drill returns the exact value of x/y.  For example, in drill:
> select div(120.524,7.6456) div from voter where voter_id=10;
> returns 15.763838024484672.
> The same query from postgres returns 15.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message