Return-Path: X-Original-To: apmail-drill-issues-archive@minotaur.apache.org Delivered-To: apmail-drill-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 38334114E5 for ; Mon, 16 Jun 2014 19:25:26 +0000 (UTC) Received: (qmail 94467 invoked by uid 500); 16 Jun 2014 19:25:26 -0000 Delivered-To: apmail-drill-issues-archive@drill.apache.org Received: (qmail 94443 invoked by uid 500); 16 Jun 2014 19:25:26 -0000 Mailing-List: contact issues-help@drill.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.incubator.apache.org Delivered-To: mailing list issues@drill.incubator.apache.org Received: (qmail 94434 invoked by uid 99); 16 Jun 2014 19:25:25 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Jun 2014 19:25:25 +0000 X-ASF-Spam-Status: No, hits=-2000.7 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Mon, 16 Jun 2014 19:25:27 +0000 Received: (qmail 93219 invoked by uid 99); 16 Jun 2014 19:25:01 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Jun 2014 19:25:01 +0000 Date: Mon, 16 Jun 2014 19:25:01 +0000 (UTC) From: "Mehant Baid (JIRA)" To: issues@drill.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Assigned] (DRILL-584) ExpressionTreeMaterializer injects incorrect implicit casts MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/DRILL-584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mehant Baid reassigned DRILL-584: --------------------------------- Assignee: Mehant Baid (was: DrillCommitter) > ExpressionTreeMaterializer injects incorrect implicit casts > ----------------------------------------------------------- > > Key: DRILL-584 > URL: https://issues.apache.org/jira/browse/DRILL-584 > Project: Apache Drill > Issue Type: Bug > Components: Execution - Codegen > Reporter: Mehant Baid > Assignee: Mehant Baid > Fix For: 1.0.0-BETA1 > > > In ExpressionTreeMaterializer.visitFunctionCall() we try to get a best match between the DrillFuncHolder and the input call. We may match the input call with a DrillFuncHolder whose argument type is different from that of the input, but is allowed to be implicitly cast as per the precedence rules. > However when we inject implicit casts to compensate for the difference in argument types, we again use the same matching method to resolve the implicit cast to DrillFuncHolder. In the case of implicit casts should not match with a DrillFuncHolder that has different argument types than the input. We should return only the DrillFuncHolder that exactly matches the argument types and if no such holder is present should return NULL. -- This message was sent by Atlassian JIRA (v6.2#6252)