drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aman Sinha (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-1091) Planner generating invalid plan for tpc-h 18
Date Sun, 29 Jun 2014 23:09:24 GMT

    [ https://issues.apache.org/jira/browse/DRILL-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14047282#comment-14047282
] 

Aman Sinha commented on DRILL-1091:
-----------------------------------

Uploaded a patch for this.  The fix is to propagate the collation trait from the Filter's
child.  Tested with manually inspecting explain plans for various queries containing HAVING
predicate in the aggregation followed by ordering requirement.  With this patch, the TPCH
18 query will do hash aggregate in both places instead of streaming aggregate. 

> Planner generating invalid plan for tpc-h 18
> --------------------------------------------
>
>                 Key: DRILL-1091
>                 URL: https://issues.apache.org/jira/browse/DRILL-1091
>             Project: Apache Drill
>          Issue Type: Bug
>            Reporter: Steven Phillips
>            Assignee: Aman Sinha
>         Attachments: 0001-Fix-Drill-1091-Filter-should-propagate-child-s-colla.patch
>
>
> The planner is currently including a streaming aggregate on l_orderkey without previously
sorting. This is causing invalid results.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message