Return-Path: X-Original-To: apmail-drill-issues-archive@minotaur.apache.org Delivered-To: apmail-drill-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 954F110FE7 for ; Wed, 28 May 2014 23:04:25 +0000 (UTC) Received: (qmail 36759 invoked by uid 500); 28 May 2014 23:04:25 -0000 Delivered-To: apmail-drill-issues-archive@drill.apache.org Received: (qmail 36736 invoked by uid 500); 28 May 2014 23:04:25 -0000 Mailing-List: contact issues-help@drill.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.incubator.apache.org Delivered-To: mailing list issues@drill.incubator.apache.org Received: (qmail 36727 invoked by uid 99); 28 May 2014 23:04:25 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 May 2014 23:04:25 +0000 X-ASF-Spam-Status: No, hits=-2000.7 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Wed, 28 May 2014 23:04:26 +0000 Received: (qmail 35733 invoked by uid 99); 28 May 2014 23:04:01 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 May 2014 23:04:01 +0000 Date: Wed, 28 May 2014 23:04:01 +0000 (UTC) From: "Jacques Nadeau (JIRA)" To: issues@drill.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (DRILL-362) Some protobuf enum values generates problematic C++/Windows code MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/DRILL-362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Nadeau resolved DRILL-362. ---------------------------------- Resolution: Won't Fix > Some protobuf enum values generates problematic C++/Windows code > ---------------------------------------------------------------- > > Key: DRILL-362 > URL: https://issues.apache.org/jira/browse/DRILL-362 > Project: Apache Drill > Issue Type: Bug > Reporter: George Chow > Priority: Minor > > The enums DataMode and MinorType (in Types.proto) each contain a value (OPTIONAL and NULL respectively) that generate into problematic C++ code on Windows under Visual Studio. > I propose to add a prefix to the enum values to uniquify them. For example: > enum DataMode { > DM_OPTIONAL = 0, > DM_REQUIRED = 1, > DM_REPEATED = 2 > } > This is slightly ugly but is ultimately safe. Unfortunately, this change will trigger a lot of little changes throughout the codebase. -- This message was sent by Atlassian JIRA (v6.2#6252)