drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jacques Nadeau (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-824) MergingRecordBatch.next() fails to reallocate the outgoing vectors if copyFromSafe returns false
Date Wed, 28 May 2014 19:29:02 GMT

    [ https://issues.apache.org/jira/browse/DRILL-824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14011481#comment-14011481
] 

Jacques Nadeau commented on DRILL-824:
--------------------------------------

Fixed in ef28054

> MergingRecordBatch.next() fails to reallocate the outgoing vectors if copyFromSafe returns
false
> ------------------------------------------------------------------------------------------------
>
>                 Key: DRILL-824
>                 URL: https://issues.apache.org/jira/browse/DRILL-824
>             Project: Apache Drill
>          Issue Type: Bug
>            Reporter: Venki Korukanti
>            Assignee: Venki Korukanti
>         Attachments: DRILL-824-1.patch
>
>
> {code}
> public IterOutcome next()
>   while (!pqueue.isEmpty())  {
>     // pop next value from pq and copy to outgoing batch
>     Node node = pqueue.peek(); 
>     if (!copyRecordToOutgoingBatch(node)) {
>       break;
>     }
>     ...
>   }
>   ...
> }
> {code}
> If the {{copyRecordToOutgoingBatch}} fails, we send the current outgoing batch, but we
don't reallocate outgoing batch when we reenter {{next}} which leads to DeadBuf exceptions.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message