drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [drill] vvysotskyi commented on a change in pull request #1810: DRILL-7271: Refactor Metadata interfaces and classes to contain all needed information for the File based Metastore
Date Mon, 24 Jun 2019 16:01:48 GMT
vvysotskyi commented on a change in pull request #1810: DRILL-7271: Refactor Metadata interfaces
and classes to contain all needed information for the File based Metastore
URL: https://github.com/apache/drill/pull/1810#discussion_r296728354
 
 

 ##########
 File path: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveDrillNativeParquetScan.java
 ##########
 @@ -228,5 +228,10 @@ public HiveDrillNativeParquetScanFilterer(HiveDrillNativeParquetScan
source) {
     protected AbstractParquetGroupScan getNewScan() {
       return new HiveDrillNativeParquetScan((HiveDrillNativeParquetScan) source);
     }
+
+    @Override
+    protected HiveDrillNativeParquetScanFilterer self() {
 
 Review comment:
   This method came from `GroupScanWithMetadataFilterer` and is used to return the correct
type of `this` instance to avoid casts in parent classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message