drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] paul-rogers commented on a change in pull request #1652: DRILL-7046: Support for loading and parsing new RM config file
Date Sat, 23 Feb 2019 23:05:17 GMT
paul-rogers commented on a change in pull request #1652: DRILL-7046: Support for loading and
parsing new RM config file
URL: https://github.com/apache/drill/pull/1652#discussion_r259596051

 File path: exec/java-exec/src/main/java/org/apache/drill/exec/resourcemgr/QueueAssignmentResult.java
 @@ -0,0 +1,73 @@
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.drill.exec.resourcemgr;
+import org.apache.drill.exec.ops.QueryContext;
+import org.apache.drill.shaded.guava.com.google.common.base.Preconditions;
+import java.util.ArrayList;
+import java.util.List;
+ * Used to keep track of selected leaf and all rejected {@link ResourcePool} for the provided
+ * It is used by {@link ResourcePoolImpl#visitAndSelectPool(QueueAssignmentResult, QueryContext)}
 Review comment:
   Javadoc comments are great. As a first-time reader, I find the comments tell me what this
is "list of selected leaf...". But, not its purpose. For example, is this the result of matching
a query request to a resource pool? Is there a .md or package-info.java file that explains
the flow so I can see how this class is supposed to fit into that context?

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

View raw message