From dev-return-44456-archive-asf-public=cust-asf.ponee.io@drill.apache.org Wed Jan 23 04:10:00 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id E585C180771 for ; Wed, 23 Jan 2019 04:09:59 +0100 (CET) Received: (qmail 56015 invoked by uid 500); 23 Jan 2019 03:09:58 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 56004 invoked by uid 99); 23 Jan 2019 03:09:58 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 23 Jan 2019 03:09:58 +0000 From: GitBox To: dev@drill.apache.org Subject: [GitHub] weijietong commented on a change in pull request #1600: DRILL-6947: fix RuntimeFilter memory leak Message-ID: <154821299799.31415.11761230712989042580.gitbox@gitbox.apache.org> Date: Wed, 23 Jan 2019 03:09:57 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit weijietong commented on a change in pull request #1600: DRILL-6947: fix RuntimeFilter memory leak URL: https://github.com/apache/drill/pull/1600#discussion_r250042732 ########## File path: exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentContextImpl.java ########## @@ -530,11 +530,11 @@ public void close() { // Close the buffers before closing the operators; this is needed as buffer ownership // is attached to the receive operators. suppressingClose(buffers); - closeNotConsumedRFWs(); // close operator context for (OperatorContextImpl opContext : contexts) { suppressingClose(opContext); } + closeNotConsumedRFWs(); Review comment: The order has no matters with the memory leak. I will revert that to the original position. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services