drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] arina-ielchiieva commented on a change in pull request #1599: DRILL-6903: SchemaBuilder code improvements
Date Wed, 09 Jan 2019 13:53:31 GMT
arina-ielchiieva commented on a change in pull request #1599: DRILL-6903: SchemaBuilder code
improvements
URL: https://github.com/apache/drill/pull/1599#discussion_r246036795
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/record/metadata/MapBuilder.java
 ##########
 @@ -123,30 +126,36 @@ public RepeatedListBuilder addRepeatedList(String name) {
     return tupleBuilder.addRepeatedList(this, name);
   }
 
-  private MapColumnMetadata buildCol() {
+  public MapColumnMetadata buildColumn() {
 
 Review comment:
   For schema ser / de we need just columns without binding to the parent. As you have correctly
mentioned, for this use case we allow parent to be null.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message