drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From arina-ielchiieva <...@git.apache.org>
Subject [GitHub] drill pull request #1083: DRILL-4185: UNION ALL involving empty directory on...
Date Tue, 09 Jan 2018 21:26:35 GMT
Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1083#discussion_r160525590
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/TestParquetGroupScan.java
---
    @@ -56,65 +56,50 @@ private void prepareTables(final String tableName, boolean refreshMetadata)
thro
       public void testFix4376() throws Exception {
         prepareTables("4376_1", true);
     
    -    testBuilder()
    -      .sqlQuery("SELECT COUNT(*) AS `count` FROM dfs.tmp.`4376_1/60*`")
    -      .ordered()
    -      .baselineColumns("count").baselineValues(1984L)
    -      .go();
    +    int actualRecordCount = testSql("SELECT * FROM dfs.tmp.`4376_1/60*`");
    +    int expectedRecordCount = 1984;
    +    assertEquals(String.format("Received unexpected number of rows in output: expected=%d,
received=%s",
    --- End diff --
    
    `expected=%d` -> `expected = %d`. Please correct here and in other cases.
      


---

Mime
View raw message