drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vvysotskyi <...@git.apache.org>
Subject [GitHub] drill pull request #570: DRILL-4834 decimal implementation is vulnerable to ...
Date Tue, 09 Jan 2018 18:52:03 GMT
Github user vvysotskyi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/570#discussion_r160481004
  
    --- Diff: exec/java-exec/src/main/codegen/templates/StringOutputRecordWriter.java ---
    @@ -146,7 +146,7 @@ public void writeField() throws IOException {
         // TODO: error check
         addField(fieldId, reader.readObject().toString());
     
    -  <#elseif minor.class == "VarChar" || minor.class == "Var16Char" || minor.class ==
"VarBinary">
    +  <#elseif minor.class == "VarChar" || minor.class == "Var16Char" || minor.class ==
"VarBinary" || minor.class == "VarDecimal">
    --- End diff --
    
    May these types be moved into previous `elseif`?
      


---

Mime
View raw message