drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vvysotskyi <...@git.apache.org>
Subject [GitHub] drill pull request #570: DRILL-4834 decimal implementation is vulnerable to ...
Date Tue, 09 Jan 2018 18:52:03 GMT
Github user vvysotskyi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/570#discussion_r160490947
  
    --- Diff: exec/vector/src/main/codegen/templates/NullableValueVectors.java ---
    @@ -327,13 +327,17 @@ public Mutator getMutator(){
         return v;
       }
     
    -  public void copyFrom(int fromIndex, int thisIndex, Nullable${minor.class}Vector from){
    +  protected void copyFromUnsafe(int fromIndex, int thisIndex, Nullable${minor.class}Vector
from){
    --- End diff --
    
    Are changes in this class necessary?


---

Mime
View raw message