drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From HanumathRao <...@git.apache.org>
Subject [GitHub] drill pull request #1059: DRILL-5851: Empty table during a join operation wi...
Date Thu, 28 Dec 2017 19:59:46 GMT
Github user HanumathRao commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1059#discussion_r158992589
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java
---
    @@ -305,11 +307,15 @@ public void executeBuildPhase() throws SchemaChangeException, ClassTransformatio
         //Setup the underlying hash table
     
         // skip first batch if count is zero, as it may be an empty schema batch
    -    if (right.getRecordCount() == 0) {
    +    if (isFurtherProcessingRequired(rightUpstream) && right.getRecordCount()
== 0) {
           for (final VectorWrapper<?> w : right) {
             w.clear();
           }
           rightUpstream = next(right);
    +      if (isFurtherProcessingRequired(rightUpstream) &&
    +          right.getRecordCount() > 0 && hashTable == null) {
    +        setupHashTable();
    --- End diff --
    
    Yes, there were some existing changes which were failing if we haven't done this check.


---

Mime
View raw message