drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vvysotskyi <...@git.apache.org>
Subject [GitHub] drill pull request #1066: DRILL-3993: Changes to support Calcite 1.15
Date Thu, 21 Dec 2017 20:44:12 GMT
Github user vvysotskyi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1066#discussion_r158374197
  
    --- Diff: exec/java-exec/src/main/codegen/includes/parserImpls.ftl ---
    @@ -351,4 +351,23 @@ SqlNode SqlDropFunction() :
        {
            return new SqlDropFunction(pos, jar);
        }
    -}
    \ No newline at end of file
    +}
    +
    +<#if !parser.includeCompoundIdentifier >
    --- End diff --
    
    Actually, it does not cause a new behaviour or functionality, it just helps to preserve
old one after changes in Calcite `Parser.jj`. Therefore existing unit tests cover this change.


---

Mime
View raw message