drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vvysotskyi <...@git.apache.org>
Subject [GitHub] drill pull request #1066: DRILL-3993: Changes to support Calcite 1.15
Date Thu, 21 Dec 2017 13:37:41 GMT
Github user vvysotskyi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1066#discussion_r158259594
  
    --- Diff: contrib/storage-jdbc/src/main/java/org/apache/drill/exec/store/jdbc/JdbcPrel.java
---
    @@ -62,7 +62,7 @@ public JdbcPrel(RelOptCluster cluster, RelTraitSet traitSet, JdbcIntermediatePre
             (JavaTypeFactory) getCluster().getTypeFactory());
         final JdbcImplementor.Result result =
             jdbcImplementor.visitChild(0, input.accept(new SubsetRemover()));
    -    sql = result.asQuery().toSqlString(dialect).getSql();
    +    sql = result.asSelect().toSqlString(dialect).getSql();
    --- End diff --
    
    It is also may be another `SqlCall` instance. Thanks for pointing this, replaced it by
`asStatement()` method.


---

Mime
View raw message