drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #1060: DRILL-5846: Improve parquet performance for Flat D...
Date Thu, 21 Dec 2017 05:13:31 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1060#discussion_r158198379
  
    --- Diff: exec/vector/src/main/codegen/templates/NullableValueVectors.java ---
    @@ -804,6 +1406,310 @@ public void fromNotNullable(${minor.class}Vector srce) {
           setValueCount(valueCount);
         }
       }
    +
    +  <#if type.major == "VarLen" && minor.class == "VarChar">
    --- End diff --
    
    Given that is (and much other code) is for a single class, does it really need to be generated
via a template?


---

Mime
View raw message