drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #1060: DRILL-5846: Improve parquet performance for Flat D...
Date Thu, 21 Dec 2017 05:13:29 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1060#discussion_r158183519
  
    --- Diff: exec/vector/src/main/codegen/templates/VariableLengthVectors.java ---
    @@ -386,7 +391,7 @@ public void reAlloc() {
           throw new OversizedAllocationException("Unable to expand the buffer. Max allowed
buffer size is reached.");
         }
     
    -    logger.trace("Reallocating VarChar, new size {}", newAllocationSize);
    +    logger.trace("Reallocating VarChar, new size {}",newAllocationSize);
    --- End diff --
    
    Most common Drill convention is to include a space after punctuation.


---

Mime
View raw message