drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #1071: DRILL-6028: Allow splitting generated code in Chai...
Date Wed, 20 Dec 2017 23:40:36 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1071#discussion_r158164670
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/TestUnionDistinct.java ---
    @@ -754,4 +756,37 @@ public void testDrill4147_1() throws Exception {
         }
       }
     
    +  @Test
    +  public void testUnionWithManyColumns() throws Exception {
    --- End diff --
    
    Why would a UNION operator need code for a generated hash table? The union matches columns,
then iterates over multiple result sets. Where would a run-time hash table fit?
    
    Do we need a different unit test that exercises the hash table code?


---

Mime
View raw message