drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ilooner <...@git.apache.org>
Subject [GitHub] drill pull request #1057: DRILL-5993 VectorContainer Append and Generic Copi...
Date Tue, 19 Dec 2017 22:35:34 GMT
Github user ilooner commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1057#discussion_r157894540
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/svremover/Copier.java
---
    @@ -19,13 +19,15 @@
     
     import org.apache.drill.exec.compile.TemplateClassDefinition;
     import org.apache.drill.exec.exception.SchemaChangeException;
    -import org.apache.drill.exec.ops.FragmentContext;
     import org.apache.drill.exec.record.RecordBatch;
    +import org.apache.drill.exec.record.VectorContainer;
     
     public interface Copier {
    -  public static TemplateClassDefinition<Copier> TEMPLATE_DEFINITION2 = new TemplateClassDefinition<Copier>(Copier.class,
CopierTemplate2.class);
    -  public static TemplateClassDefinition<Copier> TEMPLATE_DEFINITION4 = new TemplateClassDefinition<Copier>(Copier.class,
CopierTemplate4.class);
    +  TemplateClassDefinition<Copier> TEMPLATE_DEFINITION2 = new TemplateClassDefinition<Copier>(Copier.class,
CopierTemplate2.class);
    +  TemplateClassDefinition<Copier> TEMPLATE_DEFINITION4 = new TemplateClassDefinition<Copier>(Copier.class,
CopierTemplate4.class);
    --- End diff --
    
    I will create a separate PR to do that since that change is unrelated to this PR


---

Mime
View raw message