drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vrozov <...@git.apache.org>
Subject [GitHub] drill pull request #1075: DRILL-6030: Managed sort should minimize number of...
Date Tue, 19 Dec 2017 21:52:51 GMT
Github user vrozov commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1075#discussion_r157885846
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/SortConfig.java
---
    @@ -84,7 +85,7 @@ public SortConfig(DrillConfig config) {
         if (limit > 0) {
           mergeLimit = Math.max(limit, MIN_MERGE_LIMIT);
         } else {
    -      mergeLimit = Integer.MAX_VALUE;
    +      mergeLimit = DEFAULT_MERGE_LIMIT;
    --- End diff --
    
    IMO, it is better to change the default to avoid upgrade problems. In an upgrade scenario,
 users may simply overwrite `drill-override.conf` from their prior installations and forget
to set the merge limit. Is there a reason not to change the default merge limit?


---

Mime
View raw message