drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ilooner <...@git.apache.org>
Subject [GitHub] drill pull request #1057: DRILL-5993 VectorContainer Append and Generic Copi...
Date Tue, 19 Dec 2017 19:33:32 GMT
Github user ilooner commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1057#discussion_r157853697
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/svremover/CopierTemplate4.java
---
    @@ -54,17 +52,33 @@ public int copyRecords(int index, int recordCount) throws SchemaChangeException
           }
         }
     
    -    int outgoingPosition = 0;
    -    for(int svIndex = index; svIndex < index + recordCount; svIndex++, outgoingPosition++){
    +    return insertRecords(0, index, recordCount);
    +  }
    +
    +  @Override
    +  public int appendRecord(int index) throws SchemaChangeException {
    +    return appendRecords(index, 1);
    +  }
    --- End diff --
    
    Updated the code and made an implementation of appendRecord which doesn't use a for loop


---

Mime
View raw message