drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From arina-ielchiieva <...@git.apache.org>
Subject [GitHub] drill pull request #1040: Drill 5425
Date Wed, 13 Dec 2017 15:28:20 GMT
Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1040#discussion_r154690645
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebServerConstants.java
---
    @@ -0,0 +1,44 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.exec.server.rest;
    +
    +/**
    + * Holds various constants used by WebServer components.
    + */
    +public class WebServerConstants {
    +  //private static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(WebServerConstants.class);
    --- End diff --
    
    1. Please remove logger.
    2. Usually interface is used to hold constants.


---

Mime
View raw message