drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #1045: DRILL-5730 Test Mocking Improvements
Date Mon, 11 Dec 2017 20:48:01 GMT
Github user paul-rogers commented on a diff in the pull request:

    --- Diff: common/src/main/java/org/apache/drill/common/config/DrillConfig.java ---
    @@ -45,13 +45,11 @@
       private final ImmutableList<String> startupArguments;
    -  public static final boolean ON_OSX = System.getProperty("os.name").contains("OS X");
       private static final long MAX_DIRECT_MEMORY = sun.misc.VM.maxDirectMemory();
    -  public DrillConfig(Config config, boolean enableServerConfigs) {
    +  public DrillConfig(Config config) {
    --- End diff --
    I'm going to guess that the same `DrillConfig` is used (sadly) in the Drill client and
Drill server. (Sadly because it is odd for a client application to need to provide a config
file in order to connect to a Drill server. Just adds unnecessary complexity, especially for
third-party apps that happen to include a Drill JDBC driver. Sigh...)
    In the client mode, we don't want to load all the internal server configs because we'll
never use them.
    Not sure if this is actually how this flag has been used (maybe it was added, then forgotten.)
But, it is worth checking the client code to see if it was ever used.


View raw message