drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #1059: DRILL-5851: Empty table during a join operation wi...
Date Sun, 10 Dec 2017 06:38:46 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1059#discussion_r155939354
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
---
    @@ -97,6 +97,14 @@ protected void buildSchema() throws SchemaChangeException {
         VectorAccessibleUtilities.setValueCount(container,0);
       }
     
    +  @Override
    +  protected boolean checkForEarlyFinish() {
    +    if (leftUpstream == IterOutcome.NONE && rightUpstream == IterOutcome.NONE)
{
    +      return true;
    +    }
    +    return false;
    --- End diff --
    
    Convert to return of boolean expression?


---

Mime
View raw message