drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #1023: DRILL-5922 Fixed Child Allocator Leak. DRILL-5926 ...
Date Sun, 10 Dec 2017 04:55:23 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1023#discussion_r155938285
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java ---
    @@ -61,12 +63,14 @@
     public class WorkManager implements AutoCloseable {
       private static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(WorkManager.class);
     
    +  public static final long EXIT_TIMEOUT = 5_000L;
    --- End diff --
    
    Three nits:
    
    1. We'll never wait decades, so this need not be a long.
    2. Please encode units in the name: `EXIT_TIMEOUT_MS`
    3. The underscore is great, but not entirely needed for four-digit numbers.


---

Mime
View raw message