drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #1058: DRILL-6002: Avoid memory copy from direct buffer t...
Date Sat, 02 Dec 2017 00:26:56 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1058#discussion_r154477815
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/spill/SpillSet.java
---
    @@ -419,6 +462,13 @@ public SpillSet(DrillConfig config, FragmentHandle handle, PhysicalOperator
popC
             operName, handle.getMajorFragmentId(), popConfig.getOperatorId(), handle.getMinorFragmentId());
       }
     
    +  @VisibleForTesting
    +  public SpillSet(String baseDir) {
    --- End diff --
    
    We're trying to use the Hadoop `Path` class as our preferred way to pass file and directory
names around.


---

Mime
View raw message