Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
From: parthchandra <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-1050-drill@git.apache.org>
In-Reply-To: <git-pr-1050-drill@git.apache.org>
Subject: [GitHub] drill pull request #1050: DRILL-5964: Do not allow queries to access paths o...
Content-Type: text/plain
Message-Id: <20171127205112.E08D6DF9C5@git1-us-west.apache.org>
Date: Mon, 27 Nov 2017 20:51:12 +0000 (UTC)
archived-at: Mon, 27 Nov 2017 20:51:15 -0000

Github user parthchandra commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1050#discussion_r152862693
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSelection.java ---
    @@ -359,15 +363,30 @@ private static Path handleWildCard(final String root) {
         }
       }
     
    -  private static String removeLeadingSlash(String path) {
    -    if (path.charAt(0) == '/') {
    +  public static String removeLeadingSlash(String path) {
    +    if (!path.isEmpty() && path.charAt(0) == '/') {
           String newPath = path.substring(1);
           return removeLeadingSlash(newPath);
         } else {
           return path;
         }
       }
     
    +  // Check if the path is a valid sub path under the parent after removing backpaths. Throw an exception if
    +  // it is not
    +  // We pass subpath in as a parameter only for the error message
    +  public static boolean checkBackPaths(String parent, String combinedPath, String subpath) {
    --- End diff --
    
    Done


---