Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
From: paul-rogers <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-1027-drill@git.apache.org>
In-Reply-To: <git-pr-1027-drill@git.apache.org>
Subject: [GitHub] drill pull request #1027: DRILL-4779 : Kafka storage plugin
Content-Type: text/plain
Message-Id: <20171117021118.17E93F5F27@git1-us-west.apache.org>
Date: Fri, 17 Nov 2017 02:11:18 +0000 (UTC)
archived-at: Fri, 17 Nov 2017 02:11:22 -0000

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1027#discussion_r151585461
  
    --- Diff: contrib/storage-kafka/src/main/java/org/apache/drill/exec/store/kafka/KafkaSubScan.java ---
    @@ -0,0 +1,176 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.exec.store.kafka;
    +
    +import java.util.Collections;
    +import java.util.Iterator;
    +import java.util.LinkedList;
    +import java.util.List;
    +
    +import org.apache.drill.common.exceptions.ExecutionSetupException;
    +import org.apache.drill.common.expression.SchemaPath;
    +import org.apache.drill.exec.physical.base.AbstractBase;
    +import org.apache.drill.exec.physical.base.PhysicalOperator;
    +import org.apache.drill.exec.physical.base.PhysicalVisitor;
    +import org.apache.drill.exec.physical.base.SubScan;
    +import org.apache.drill.exec.store.StoragePluginRegistry;
    +
    +import com.fasterxml.jackson.annotation.JacksonInject;
    +import com.fasterxml.jackson.annotation.JsonCreator;
    +import com.fasterxml.jackson.annotation.JsonIgnore;
    +import com.fasterxml.jackson.annotation.JsonProperty;
    +import com.fasterxml.jackson.annotation.JsonTypeName;
    +import com.google.common.base.Preconditions;
    +
    +@JsonTypeName("kafka-partition-scan")
    +public class KafkaSubScan extends AbstractBase implements SubScan {
    +
    +  @JsonProperty
    +  private final KafkaStoragePluginConfig kafkStoragePluginConfig;
    +
    +  @JsonIgnore
    +  private final KafkaStoragePlugin kafkaStoragePlugin;
    +  private final List<SchemaPath> coulmns;
    +  private final List<KafkaSubScanSpec> partitionSubScanSpecList;
    +
    +  @JsonCreator
    +  public KafkaSubScan(@JacksonInject StoragePluginRegistry registry, @JsonProperty("userName") String userName,
    +      @JsonProperty("kafkStoragePluginConfig") KafkaStoragePluginConfig kafkStoragePluginConfig,
    +      @JsonProperty("coulmns") List<SchemaPath> coulmns,
    --- End diff --
    
    Spelling. Since this is a public API, might as well get it right.


---