Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
From: laurentgo <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-1024-drill@git.apache.org>
In-Reply-To: <git-pr-1024-drill@git.apache.org>
Subject: [GitHub] drill pull request #1024: DRILL-3640: Support JDBC Statement.setQueryTimeout...
Content-Type: text/plain
Message-Id: <20171108001530.90F43DFF9B@git1-us-west.apache.org>
Date: Wed,  8 Nov 2017 00:15:30 +0000 (UTC)
archived-at: Wed, 08 Nov 2017 00:15:33 -0000

Github user laurentgo commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1024#discussion_r149542622
  
    --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillCursor.java ---
    @@ -239,6 +261,11 @@ QueryDataBatch getNext() throws UserException, InterruptedException {
                 }
                 return qdb;
               }
    +
    +          // Check and throw SQLTimeoutException
    +          if ( parent.timeoutInMilliseconds > 0 && parent.elapsedTimer.elapsed(TimeUnit.SECONDS) >= parent.timeoutInMilliseconds ) {
    --- End diff --
    
    wrong unit for the comparison (should be millis)


---