Return-Path: <dev-return-33174-archive-asf-public=cust-asf.ponee.io@drill.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 191AB200D34
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Fri,  3 Nov 2017 20:38:15 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id 179D5160BFD; Fri,  3 Nov 2017 19:38:15 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 5DB7A160BDE
	for <archive-asf-public@cust-asf.ponee.io>; Fri,  3 Nov 2017 20:38:14 +0100 (CET)
Received: (qmail 52339 invoked by uid 500); 3 Nov 2017 19:38:13 -0000
Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@drill.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@drill.apache.org>
List-Post: <mailto:dev@drill.apache.org>
List-Id: <dev.drill.apache.org>
Reply-To: dev@drill.apache.org
Delivered-To: mailing list dev@drill.apache.org
Received: (qmail 52275 invoked by uid 99); 3 Nov 2017 19:38:13 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Nov 2017 19:38:13 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 0E226DFB3D; Fri,  3 Nov 2017 19:38:13 +0000 (UTC)
From: bitblender <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-921-drill@git.apache.org>
In-Reply-To: <git-pr-921-drill@git.apache.org>
Subject: [GitHub] drill pull request #921: DRILL-4286 Graceful shutdown of drillbit
Content-Type: text/plain
Message-Id: <20171103193813.0E226DFB3D@git1-us-west.apache.org>
Date: Fri,  3 Nov 2017 19:38:13 +0000 (UTC)
archived-at: Fri, 03 Nov 2017 19:38:15 -0000

Github user bitblender commented on a diff in the pull request:

    https://github.com/apache/drill/pull/921#discussion_r148684246
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/ZKClusterCoordinator.java ---
    @@ -70,7 +72,10 @@
       private final CountDownLatch initialConnection = new CountDownLatch(1);
       private final TransientStoreFactory factory;
       private ServiceCache<DrillbitEndpoint> serviceCache;
    +  private DrillbitEndpoint endpoint;
     
    +//private HashMap<MultiKey, DrillbitEndpoint> endpointsMap = new HashMap<MultiKey, DrillbitEndpoint>();
    +  private ConcurrentHashMap<MultiKey, DrillbitEndpoint> endpointsMap = new ConcurrentHashMap<MultiKey,DrillbitEndpoint>();
    --- End diff --
    
    please add a comment about what this map contains. 


---