drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cgivre <...@git.apache.org>
Subject [GitHub] drill pull request #1043: DRILL-5981: Add Syntax Highlighting and Error Chec...
Date Mon, 20 Nov 2017 21:08:53 GMT
GitHub user cgivre opened a pull request:

    https://github.com/apache/drill/pull/1043

    DRILL-5981: Add Syntax Highlighting and Error Checking to Storage Plugin Config

    This PR adds syntax highlighting to the storage plugin configuration page in the Drill
web UI, as shown below.
    ![screen shot 2017-11-20 at 16 05 27](https://user-images.githubusercontent.com/5513150/33041572-c9e79f18-ce0c-11e7-8b83-0956d4d2516f.png)
    
    In addition, and the real reason I'd like to see this included is that it also incorporates
error checking, again as shown below:
    
    ![screen shot 2017-11-20 at 16 05 39](https://user-images.githubusercontent.com/5513150/33041601-e39adf4c-ce0c-11e7-9514-4121fdf92ec0.png)
    
    I know there is some objection about including javascript libraries in Drill.  However,
I work on a closed network and it is difficult if not impossible to build Drill from source
if the libraries are not included.   I removed all JavaScript files except the bare minimum.

    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cgivre/drill syntax-highlighting-storage-plugin

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/1043.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1043
    
----
commit 8e1d52a3d9b08d789574e213fd07721e5b02cedf
Author: cgivre <cgivre@gmail.com>
Date:   2017-11-20T20:43:23Z

    Initial Commit
    
    Final Commits
    Adds syntax highlighting and error checking to plugin configuration page.
    Removed extraneous files

----


---

Mime
View raw message