drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben-Zvi <...@git.apache.org>
Subject [GitHub] drill pull request #1057: DRILL-5993 Append Row Method For VectorContainer (...
Date Wed, 29 Nov 2017 22:33:30 GMT
Github user Ben-Zvi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1057#discussion_r153935071
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/record/TestVectorContainer.java
---
    @@ -124,4 +132,52 @@ public void testContainerMerge() {
         leftIndirect.clear();
         right.clear();
       }
    +
    +  @Test
    +  public void testAppendRow()
    +  {
    +    MaterializedField colA = MaterializedField.create("colA", Types.required(TypeProtos.MinorType.INT));
    +    MaterializedField colB = MaterializedField.create("colB", Types.required(TypeProtos.MinorType.INT));
    --- End diff --
    
     Maybe add some "interesting" datatypes ?  Testing integers only may miss some issue.




---

Mime
View raw message