drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From arina-ielchiieva <...@git.apache.org>
Subject [GitHub] drill pull request #1050: DRILL-5964: Do not allow queries to access paths o...
Date Tue, 28 Nov 2017 09:35:09 GMT
Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1050#discussion_r153436976
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/WorkspaceConfig.java
---
    @@ -30,18 +30,24 @@
     public class WorkspaceConfig {
     
       /** Default workspace is a root directory which supports read, but not write. */
    -  public static final WorkspaceConfig DEFAULT = new WorkspaceConfig("/", false, null);
    +  public static final WorkspaceConfig DEFAULT = new WorkspaceConfig("/", false, null,
false);
     
       private final String location;
       private final boolean writable;
       private final String defaultInputFormat;
    -
    +  private final Boolean allowAccessOutsideWorkspace; // allow access outside the workspace
by default. This
    --- End diff --
    
    1. Can we adjust the variable to be false by default, i.e. rename it to `disallowAccessOutsideWorkspace`?
Thus we'll be able to use primitive, right?
    2. In the below code you always set `this.allowAccessOutsideWorkspace = true;`, block
with `this.allowAccessOutsideWorkspace = allowAccessOutsideWorkspace != null ? allowAccessOutsideWorkspace
: false ;` is commented. I guess this is a mistake.


---

Mime
View raw message