drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From arina-ielchiieva <...@git.apache.org>
Subject [GitHub] drill pull request #1033: DRILL-5952: Implement "CREATE TABLE IF NOT EXISTS"
Date Wed, 22 Nov 2017 14:45:45 GMT
Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1033#discussion_r152579484
  
    --- Diff: exec/java-exec/src/main/codegen/includes/parserImpls.ftl ---
    @@ -215,11 +223,12 @@ SqlNode SqlDropView() :
     
     /**
      * Parses a CTAS or CTTAS statement.
    - * CREATE [TEMPORARY] TABLE tblname [ (field1, field2, ...) ] AS select_statement.
    + * CREATE [TEMPORARY] TABLE [IF NOT EXISTS] tblname [ (field1, field2, ...) ] AS select_statement.
      */
     SqlNode SqlCreateTable() :
     {
         SqlParserPos pos;
    +    boolean tableNonExistenceCheck = false;
    --- End diff --
    
    Not critical but I am in favor of adding new parameters in the end. Of course if logically
it is not required.


---

Mime
View raw message