drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kameshb <...@git.apache.org>
Subject [GitHub] drill pull request #1027: DRILL-4779 : Kafka storage plugin
Date Tue, 21 Nov 2017 15:34:39 GMT
Github user kameshb commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1027#discussion_r152310859
  
    --- Diff: contrib/storage-kafka/src/test/java/org/apache/drill/exec/store/kafka/TestKafkaSuit.java
---
    @@ -0,0 +1,102 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.exec.store.kafka;
    +
    +import java.util.Properties;
    +import java.util.concurrent.atomic.AtomicInteger;
    +
    +import org.I0Itec.zkclient.ZkClient;
    +import org.I0Itec.zkclient.ZkConnection;
    +import org.apache.drill.exec.store.kafka.cluster.EmbeddedKafkaCluster;
    +import org.apache.kafka.common.serialization.StringSerializer;
    +import org.junit.AfterClass;
    +import org.junit.BeforeClass;
    +import org.junit.runner.RunWith;
    +import org.junit.runners.Suite;
    +import org.junit.runners.Suite.SuiteClasses;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import com.google.common.base.Joiner;
    +
    +import kafka.admin.AdminUtils;
    +import kafka.admin.RackAwareMode;
    +import kafka.utils.ZKStringSerializer$;
    +import kafka.utils.ZkUtils;
    +
    +@RunWith(Suite.class)
    +@SuiteClasses({ KafkaQueriesTest.class, MessageIteratorTest.class })
    +public class TestKafkaSuit {
    --- End diff --
    
    Thanks for suggesting this frameworks.  I think this may take considerable amount of time
and since release date is very close, we will address this refactoring by next release.


---

Mime
View raw message