drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bitblender <...@git.apache.org>
Subject [GitHub] drill pull request #914: DRILL-5657: Size-aware vector writer structure
Date Fri, 17 Nov 2017 19:02:19 GMT
Github user bitblender commented on a diff in the pull request:

    https://github.com/apache/drill/pull/914#discussion_r151762298
  
    --- Diff: exec/vector/src/main/codegen/templates/ColumnAccessors.java ---
    @@ -275,17 +273,17 @@ public boolean isNull() {
           final int offset = writeIndex(len);
           <#else>
           final int writeIndex = writeIndex();
    -      <#assign putAddr = "bufAddr + writeIndex * VALUE_WIDTH">
    +      <#assign putAddr = "writeIndex * VALUE_WIDTH">
    --- End diff --
    
    putAddr is not an address but an offset, right ? Should be renamed. 


---

Mime
View raw message