drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From arina-ielchiieva <...@git.apache.org>
Subject [GitHub] drill pull request #1032: DRILL-5089: Dynamically load schema of storage plu...
Date Fri, 17 Nov 2017 17:10:06 GMT
Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1032#discussion_r151714418
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSystemSchemaFactory.java
---
    @@ -50,11 +53,23 @@
     
       public static final String DEFAULT_WS_NAME = "default";
     
    +  public static final String LOCAL_FS_SCHEME = "file";
    +
       private List<WorkspaceSchemaFactory> factories;
       private String schemaName;
    +  protected FileSystemPlugin plugin;
     
       public FileSystemSchemaFactory(String schemaName, List<WorkspaceSchemaFactory>
factories) {
    -    super();
    +    // when the correspondent FileSystemPlugin is not passed in, we dig into ANY workspace
factory to get it.
    +    if (factories.size() > 0 ) {
    --- End diff --
    
    Please remove space `if (factories.size() > 0) {`.


---

Mime
View raw message