drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From arina-ielchiieva <...@git.apache.org>
Subject [GitHub] drill pull request #1032: DRILL-5089: Dynamically load schema of storage plu...
Date Fri, 17 Nov 2017 17:10:06 GMT
Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1032#discussion_r151732963
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/WorkspaceSchemaFactory.java
---
    @@ -373,12 +402,12 @@ public String toString() {
       public class WorkspaceSchema extends AbstractSchema implements ExpandingConcurrentMap.MapValueFactory<TableInstance,
DrillTable> {
         private final ExpandingConcurrentMap<TableInstance, DrillTable> tables = new
ExpandingConcurrentMap<>(this);
         private final SchemaConfig schemaConfig;
    -    private final DrillFileSystem fs;
    +    private DrillFileSystem fs;
     
    -    public WorkspaceSchema(List<String> parentSchemaPath, String wsName, SchemaConfig
schemaConfig) throws IOException {
    +    public WorkspaceSchema(List<String> parentSchemaPath, String wsName, SchemaConfig
schemaConfig, DrillFileSystem fs) throws IOException {
           super(parentSchemaPath, wsName);
           this.schemaConfig = schemaConfig;
    -      this.fs = ImpersonationUtil.createFileSystem(schemaConfig.getUserName(), fsConf);
    +      this.fs = fs;
    --- End diff --
    
    Why don't we anymore need to create fs using `ImpersonationUtil` but needed before?


---

Mime
View raw message