drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #1027: DRILL-4779 : Kafka storage plugin
Date Fri, 17 Nov 2017 02:11:18 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1027#discussion_r151584428
  
    --- Diff: contrib/storage-kafka/src/main/java/org/apache/drill/exec/store/kafka/decoders/MessageReader.java
---
    @@ -0,0 +1,45 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.exec.store.kafka.decoders;
    +
    +import java.io.Closeable;
    +import java.util.List;
    +
    +import org.apache.drill.common.expression.SchemaPath;
    +import org.apache.drill.exec.store.kafka.KafkaStoragePlugin;
    +import org.apache.drill.exec.vector.complex.impl.VectorContainerWriter;
    +import org.apache.kafka.clients.consumer.ConsumerRecord;
    +import org.apache.kafka.clients.consumer.KafkaConsumer;
    +
    +import io.netty.buffer.DrillBuf;
    +
    +/**
    + * MessageReader interface provides mechanism to handle various Kafka Message
    + * Formats like JSON, AVRO or custom message formats.
    + */
    +public interface MessageReader  extends Closeable {
    +
    +  public void init(DrillBuf buf, List<SchemaPath> columns, VectorContainerWriter
writer, boolean allTextMode,
    +      boolean skipOuterList, boolean readNumbersAsDouble);
    --- End diff --
    
    Does `skipOuterList` make sense here? It is for for files of the form:
    
    ```
    [
      {name: "first record}
      {name: "secondRecord}
    ]
    ```
    
    But, each Kafka record *is* a document, so the "outer list" pattern can never occur.


---

Mime
View raw message