drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dvjyothsna <...@git.apache.org>
Subject [GitHub] drill pull request #921: DRILL-4286 Graceful shutdown of drillbit
Date Tue, 14 Nov 2017 23:20:14 GMT
Github user dvjyothsna commented on a diff in the pull request:

    https://github.com/apache/drill/pull/921#discussion_r150993718
  
    --- Diff: exec/java-exec/src/main/resources/rest/index.ftl ---
    @@ -57,19 +57,19 @@
                   <th>Control Port</th>
                   <th>Data Port</th>
                   <th>Version</th>
    +              <th>Status</th>
                 </tr>
               </thead>
               <tbody>
                 <#assign i = 1>
                 <#list model.getDrillbits() as drillbit>
    -              <tr>
    +              <tr id="row-${i}">
                     <td>${i}</td>
    -                <td>${drillbit.getAddress()}
    -                  <#if drillbit.isCurrent()>
    +                <td id="address" >${drillbit.getAddress()}<#if drillbit.isCurrent()>
                         <span class="label label-info">Current</span>
                       </#if>
                     </td>
    -                <td>${drillbit.getUserPort()}</td>
    +                <td id="port" >${drillbit.getUserPort()}</td>
    --- End diff --
    
    Yes, true. But for every row I have a different ID ("row-1") and I'm accessing "port"(child)
of that row.  This was the entire row is unique and need not assign  a new unique id for every
element in that row. Am I missing something here?


---

Mime
View raw message