drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #921: DRILL-4286 Graceful shutdown of drillbit
Date Tue, 14 Nov 2017 22:41:48 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/921#discussion_r150977759
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/DrillRoot.java
---
    @@ -58,13 +63,170 @@
       @Inject UserAuthEnabled authEnabled;
       @Inject WorkManager work;
       @Inject SecurityContext sc;
    +  @Inject Drillbit drillbit;
     
       @GET
       @Produces(MediaType.TEXT_HTML)
       public Viewable getClusterInfo() {
         return ViewableWithPermissions.create(authEnabled.get(), "/rest/index.ftl", sc, getClusterInfoJSON());
       }
     
    +
    +  @SuppressWarnings("resource")
    +  @GET
    +  @Path("/state")
    +  @Produces(MediaType.APPLICATION_JSON)
    +  public Response getDrillbitStatus(){
    +    Collection<DrillbitInfo> drillbits = getClusterInfoJSON().getDrillbits();
    +    Map<String, String> drillStatusMap = new HashMap<String ,String>();
    +    for (DrillbitInfo drillbit : drillbits) {
    +      drillStatusMap.put(drillbit.getAddress()+"-"+drillbit.getUserPort(),drillbit.getState());
    --- End diff --
    
    Small point: spaces around `+`


---

Mime
View raw message