drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill issue #914: DRILL-5657: Size-aware vector writer structure
Date Tue, 14 Nov 2017 19:17:28 GMT
Github user paul-rogers commented on the issue:

    https://github.com/apache/drill/pull/914
  
    @parthchandra, thank you for taking the time to review this large chunk of code. Thanks
for noticing the tests; I see those as the only way to ensure that a change of this size actually
works; expecting a human to "mentally execute" the code is not practical at this scale.
    
    I did incorporate the change you suggested for grabbing the chunk size from `PooledByteBufAllocatorL`
via a new static method in `AllocationManager`. Very good suggestion; thanks.


---

Mime
View raw message