drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #1026: DRILL-5919: Add non-numeric support for JSON proce...
Date Mon, 13 Nov 2017 22:49:08 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1026#discussion_r150688949
  
    --- Diff: exec/java-exec/src/main/resources/drill-module.conf ---
    @@ -502,6 +502,8 @@ drill.exec.options: {
         store.format: "parquet",
         store.hive.optimize_scan_with_native_readers: false,
         store.json.all_text_mode: false,
    +    store.json.writer.non_numeric_numbers: false,
    +    store.json.reader.non_numeric_numbers: false,
    --- End diff --
    
    See discussion below. If they are off, then queries that use NaN and Infinity will fail
until the user turns them on. Queries that don't use NaN and Infinity won't care. So, what
is the advantage to failing queries unnecessarily?


---

Mime
View raw message