drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #1026: DRILL-5919: Add non-numeric support for JSON proce...
Date Mon, 13 Nov 2017 22:49:08 GMT
Github user paul-rogers commented on a diff in the pull request:

    --- Diff: exec/java-exec/src/main/resources/drill-module.conf ---
    @@ -502,6 +502,8 @@ drill.exec.options: {
         store.format: "parquet",
         store.hive.optimize_scan_with_native_readers: false,
         store.json.all_text_mode: false,
    +    store.json.writer.non_numeric_numbers: false,
    +    store.json.reader.non_numeric_numbers: false,
    --- End diff --
    OK. So, if the rest of Drill either does not support (or we don't know if it supports)
NaN and Inf, should we introduce the change here that potentially leads to failures elsewhere?
    Do we know if JDBC and ODBC support these values? (I suppose they do as they are features
of Java's float/double primitives...)


View raw message