drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #1026: DRILL-5919: Add non-numeric support for JSON proce...
Date Fri, 10 Nov 2017 23:48:07 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1026#discussion_r150359510
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/JsonConvertFrom.java
---
    @@ -91,4 +92,60 @@ public void eval(){
         }
       }
     
    +  @FunctionTemplate(name = "convert_fromJSON", scope = FunctionScope.SIMPLE, nulls =
NullHandling.NULL_IF_NULL, isRandom = true)
    +  public static class ConvertFromJsonVarcharNonNumerics implements DrillSimpleFunc{
    +
    +    @Param VarCharHolder in;
    +    @Param BitHolder enableNonNumeric;
    +    @Inject DrillBuf buffer;
    +    @Workspace org.apache.drill.exec.vector.complex.fn.JsonReader jsonReader;
    +
    +    @Output ComplexWriter writer;
    +
    +    public void setup(){
    +      jsonReader = new org.apache.drill.exec.vector.complex.fn.JsonReader(buffer, false,
false, false,/* do not read numbers as doubles */
    --- End diff --
    
    See above.


---

Mime
View raw message